Fix mb_ereg_search_getregs() NULL pointer dereference#21037
Closed
vi3tL0u1s wants to merge 1 commit intophp:PHP-8.4from
Closed
Fix mb_ereg_search_getregs() NULL pointer dereference#21037vi3tL0u1s wants to merge 1 commit intophp:PHP-8.4from
vi3tL0u1s wants to merge 1 commit intophp:PHP-8.4from
Conversation
Member
|
Thank you for the patch! Please target 8.4 for non-security issues. |
vi3tL0u1s
force-pushed
the
fix-mb-ereg-search-getregs-null
branch
from
148a155 to
0ef6fb1
Compare
vi3tL0u1s
requested review from
Girgias,
SakiTakamachi,
TimWolla,
adoy,
arnaud-lb,
derickr,
dstogov,
kocsismate and
ndossche
as code owners
Author
|
Thanks for the feedback. To avoid any confusion, I will open a new clean pull request against PHP-8.4 containing only the intended changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NULL check for
MBREX(search_re)before callingonig_number_of_names()inmb_ereg_search_getregs()to prevent crash whenmb_eregi()invalidates the regex cache.Fixes GH-21036